Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Nov 11, 2024

We are observing an issue in CI where the dist/ folder is included in the formatting check and is causing CI to fail. This commit will solve this issue by delaying the compilation step until the compiled JS is required. This change will also make the earlier CI steps fail or pass faster, since we won't have to compile all the modules before linting the commit messages, for example.

Ticket: VL-2478

@ghost ghost force-pushed the only-build-packages-before-unit-tests branch 2 times, most recently from afa168c to 0c3c048 Compare November 11, 2024 16:27
@ghost ghost force-pushed the only-build-packages-before-unit-tests branch from 0c3c048 to b3b9315 Compare November 11, 2024 16:36
@ghost ghost marked this pull request as ready for review November 11, 2024 16:49
@ghost ghost self-requested a review as a code owner November 11, 2024 16:49
@ghost ghost self-requested a review November 11, 2024 16:49
@ghost ghost self-requested a review as a code owner November 11, 2024 16:49
@ghost ghost requested review from margueriteblair and pranavjain97 November 11, 2024 16:49
@ghost ghost merged commit 1c8e7b2 into master Nov 11, 2024
6 checks passed
@ghost ghost deleted the only-build-packages-before-unit-tests branch November 11, 2024 19:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants