chore: onboard GoUSD token with eth prefix WIN-4114 #5342
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rv-bitgo
changed the title
rv-bitgo
force-pushed
the
make_gousd_eth_again
branch
from
3816c32 to
cafedba
Compare
sachushaji
reviewed
Jan 7, 2025
| TGBP = 'tgbp', | ||
| TUSDS = 'tusds', | ||
| TGOUSD = 'tgousd', | ||
| GOUSD = 'gousd', |
Contributor
There was a problem hiding this comment.
why do we need to change the base to eth: gousd?, only name needs to be changed?
Contributor
Author
There was a problem hiding this comment.
Changing base isn't required but I just follow the convention since starting and since there are no enforcing rules, I stick to prefix eth to erc20 tokens.
| 6, | ||
| '0xf1f6b8cc3a0d544a40f1d29909396378370e6938', | ||
| UnderlyingAsset.GOUSD | ||
| UnderlyingAsset['eth:gousd'] |
Contributor
There was a problem hiding this comment.
no need to change the token name with eth prefixed?
WIN-4114 feat(statics): update symbol to use eth prefix
rv-bitgo
force-pushed
the
make_gousd_eth_again
branch
from
c17f913 to
14e8ce2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIN-4114