fix(ecdsa): add validation for unsigned txHex #5739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mullapudipruthvik
force-pushed
the
COIN-3222
branch
6 times, most recently
from
f90e280 to
8eb298c
Compare
mullapudipruthvik
force-pushed
the
COIN-3222
branch
from
8eb298c to
4a5ba60
Compare
margueriteblair
approved these changes
Mar 14, 2025
alebusse
reviewed
Mar 14, 2025
| if (txParams.recipients && txParams.recipients.length > 0) { | ||
| const transaction = await this.getBuilder().from(rawTx).build(); | ||
| const explainedTx = transaction.explainTransaction(); | ||
| const filteredRecipients = txParams.recipients?.map((recipient) => _.pick(recipient, ['address', 'amount'])); |
There was a problem hiding this comment.
i think leaving this outside of the if condition provides a validation since parsing the tx its also a validation
Contributor
Author
There was a problem hiding this comment.
I'll look at this again as a part of https://bitgoinc.atlassian.net/browse/COIN-3429
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: COIN-3222
TICKET: COIN-3222
This commit adds basic validation for
ecdsacoinsWe have created sub tasks to verify validation for each ecdsa coin and also for eddsa coins
https://bitgoinc.atlassian.net/browse/COIN-3429
https://bitgoinc.atlassian.net/browse/COIN-3430