Skip to content

feat: add includeBalance parameter to wallet query options #5856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkaplanbitgo merged 1 commit into from
Mar 28, 2025
Merged

feat: add includeBalance parameter to wallet query options #5856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,10 @@ describe('Lightning signer routes', () => {
includingOptionalFields ? 'with' : 'without'
} optional fields`, async () => {
const readFileStub = sinon.stub(fs.promises, 'readFile').resolves(JSON.stringify(lightningSignerConfigs));
const wpWalletnock = nock(bgUrl).get(`/api/v2/tlnbtc/wallet/${apiData.wallet.id}`).reply(200, apiData.wallet);
const wpWalletnock = nock(bgUrl)
.get(`/api/v2/tlnbtc/wallet/${apiData.wallet.id}`)
.query({ includeBalance: false })
.reply(200, apiData.wallet);

const wpKeychainNocks = [
nock(bgUrl).get(`/api/v2/tlnbtc/key/${apiData.userKey.id}`).reply(200, apiData.userKey),
Expand Down Expand Up @@ -92,6 +95,7 @@ describe('Lightning signer routes', () => {
const readFileStub = sinon.stub(fs.promises, 'readFile').resolves(JSON.stringify(lightningSignerConfigs));
const wpWalletnock = nock(bgUrl)
.get(`/api/v2/tlnbtc/wallet/${apiData.wallet.id}`)
.query({ includeBalance: false })
.reply(200, {
...apiData.wallet,
...(includeWatchOnlyIp ? {} : { watchOnlyExternalIp: null }),
Expand Down
4 changes: 4 additions & 0 deletions modules/sdk-core/src/bitgo/wallet/wallets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,6 +926,10 @@ export class Wallets implements IWallets {
query.allTokens = params.allTokens;
}

if (params.includeBalance !== undefined) {
query.includeBalance = params.includeBalance;
}

this.bitgo.setRequestTracer(params.reqId || new RequestTracer());

const wallet = await this.bitgo
Expand Down