feat(sdk-coin-apt): add generic NFT collection statics #5868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavidhingra
force-pushed
the
coin-3613-generic-nft-statics
branch
from
15e6edb to
9889624
Compare
baltiyal
previously requested changes
Apr 1, 2025
Contributor
baltiyal
left a comment
baltiyal
left a comment
There was a problem hiding this comment.
Test cases are failing. Please fix it.
bhavidhingra
force-pushed
the
coin-3613-generic-nft-statics
branch
from
9889624 to
0ff9090
Compare
baltiyal
reviewed
Apr 2, 2025
baltiyal
reviewed
Apr 2, 2025
bhavidhingra
force-pushed
the
coin-3613-generic-nft-statics
branch
from
0ff9090 to
4a3affe
Compare
bhavidhingra
force-pushed
the
coin-3613-generic-nft-statics
branch
from
4a3affe to
519935b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a generic way of defining NFT collections. It will be used to onboard Aptos NFTs.
The aim is to support specific NFT collection IDs.
TICKET: COIN-3613