refactor(sdk-coin-eos): use token symbol while verifying transaction #6280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mukeshsp
requested changes
Jun 11, 2025
|
|
||
| if (txPrebuild.coin === 'eos' || txPrebuild.coin === 'teos') { | ||
| const expectedSymbol = _.isNil(txPrebuild.token) ? 'EOS' : txPrebuild.token.split(':')[1]; | ||
| const expectedSymbol = _.isNil(txPrebuild.token) ? 'EOS' : (coins.get(txPrebuild.token) as EosCoin).symbol; |
Contributor
There was a problem hiding this comment.
Can we pass tokenSymbol as a parameter instead of fetching it from statics?
As you know, we're working on removing the statics dependency from the module as part of the AMS integration. So, let's avoid using statics for any new integrations.
Contributor
Author
There was a problem hiding this comment.
It cannot be passed down, it can only be fetched from statics coin map in current state. Moreover this function is not used to build transactions on wp, it's used on client side to verify the build obtained from wp.
mukeshsp
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-5533