Skip to content

Conversation

@MohammedRyaan786
Copy link
Contributor

TICKET: COIN-4915

@MohammedRyaan786 MohammedRyaan786 marked this pull request as ready for review July 23, 2025 16:38
@MohammedRyaan786 MohammedRyaan786 requested review from a team as code owners July 23, 2025 16:38
Copy link
Contributor

@baltiyal baltiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add test cases.

Copy link
Contributor

@baltiyal baltiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is coinFactory, browser.spec.ts, and other files are left out intentionally?
If yes, please you could explain.

@MohammedRyaan786 MohammedRyaan786 marked this pull request as draft July 24, 2025 13:08
@MohammedRyaan786
Copy link
Contributor Author

Have added tests to validate config details

@MohammedRyaan786 MohammedRyaan786 marked this pull request as ready for review July 24, 2025 13:42
Copy link
Contributor

@baltiyal baltiyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@MohammedRyaan786 MohammedRyaan786 merged commit dfea51b into master Jul 24, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants