feat: add cosmos token to coinFactory #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohammedRyaan786
force-pushed
the
COIN-4916-sdk-add-ylds-token-support
branch
7 times, most recently
from
5544f18 to
f87f706
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds Cosmos token support to the coin factory to enable creation and management of Cosmos-based tokens. This enhancement extends the existing token framework to support the Cosmos ecosystem.
- Adds
CosmosTokenConfigtype to the token configuration system - Integrates
CosmosTokenclass into the coin factory registration and constructor lookup - Updates Cosmos sidechain features to include token support
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/statics/src/tokenConfig.ts | Adds CosmosTokenConfig to union types and token creation logic |
| modules/statics/src/coins.ts | Implements Cosmos token creation logic in createToken function |
| modules/statics/src/coinFeatures.ts | Adds SUPPORTS_TOKENS feature to Cosmos sidechain capabilities |
| modules/bitgo/test/browser/browser.spec.ts | Updates test expectations to include CosmosToken |
| modules/bitgo/src/v2/coins/index.ts | Exports CosmosToken class |
| modules/bitgo/src/v2/coinFactory.ts | Registers Cosmos token constructors and adds token constructor lookup |
| modules/bitgo/package.json | Adds abstract-cosmos dependency |
| modules/abstract-cosmos/src/cosmosToken.ts | Makes token configurations parameter configurable |
MohammedRyaan786
force-pushed
the
COIN-4916-sdk-add-ylds-token-support
branch
from
f87f706 to
5245c50
Compare
kaustubhbitgo
approved these changes
Jul 25, 2025
baltiyal
reviewed
Jul 28, 2025
| case 'near': | ||
| case 'tnear': | ||
| return Nep141Token.createTokenConstructor(tokenConfig as Nep141TokenConfig); | ||
| case 'asi': |
Contributor
There was a problem hiding this comment.
Please don't add all cosmos coins.
Remove all the coins which don't support tokens currently.
This is just increasing lines of code and can also confuse someone.
baltiyal
reviewed
Jul 28, 2025
| token.isToken, // isToken | ||
| token.kind // kind | ||
| ); | ||
| case 'asi': |
Contributor
There was a problem hiding this comment.
Please don't add all cosmos coins.
Remove all the coins which don't support tokens currently.
This is just increasing lines of code and can also confuse someone.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-4915