feat: add sol mint and burn instruction functions #6564
Conversation
raj-bitgo
force-pushed
the
TMS-977-sol-mint-burn-instructions
branch
from
e8e88ea to
5e15b3a
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Solana token mint and burn operations to the SDK, enabling both standard SPL token and Token-2022 program instructions.
- Implements mint and burn instruction factories and parsers
- Adds comprehensive test coverage for both standard SPL and Token-2022 programs
- Updates utilities to properly detect and handle mint/burn instruction types
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| modules/sdk-coin-sol/src/lib/constants.ts | Adds MintTo and Burn instruction type enums |
| modules/sdk-coin-sol/src/lib/iface.ts | Defines MintTo and Burn interfaces with required parameters |
| modules/sdk-coin-sol/src/lib/utils.ts | Updates instruction type detection to recognize mint and burn operations |
| modules/sdk-coin-sol/src/lib/solInstructionFactory.ts | Implements mintToInstruction and burnInstruction factory functions |
| modules/sdk-coin-sol/src/lib/instructionParamsFactory.ts | Adds parsing logic for mint and burn instructions |
| modules/sdk-coin-sol/test/unit/solInstructionFactory.ts | Comprehensive test coverage for instruction factory functions |
| modules/sdk-coin-sol/test/unit/instructionParamsFactory.ts | Test coverage for instruction parsing functionality |
| burnInstr = createBurnInstruction(account, mint, authority, amountBN.toNumber(), [], TOKEN_2022_PROGRAM_ID); | ||
| } else { | ||
| burnInstr = createBurnInstruction(account, mint, authority, amountBN.toNumber()); |
There was a problem hiding this comment.
Converting BigNumber to number using .toNumber() may cause precision loss for large amounts. Consider using .toString() and BigInt conversion instead.
| burnInstr = createBurnInstruction(account, mint, authority, amountBN.toNumber(), [], TOKEN_2022_PROGRAM_ID); | |
| } else { | |
| burnInstr = createBurnInstruction(account, mint, authority, amountBN.toNumber()); | |
| burnInstr = createBurnInstruction(account, mint, authority, BigInt(amountBN.toString()), [], TOKEN_2022_PROGRAM_ID); | |
| } else { | |
| burnInstr = createBurnInstruction(account, mint, authority, BigInt(amountBN.toString())); |
There was a problem hiding this comment.
+1, actually this is a good point
There was a problem hiding this comment.
But, since SPL tokens only have 9 decimal places, this should probably be okay as well, double check
There was a problem hiding this comment.
converted into bigint anyway just in case
|
|
||
| // Check for burn instructions (instruction code 8) | ||
| try { | ||
| let burnInstruction; |
- Added functions to support mints and burns for sol TICKET: TMS-977
raj-bitgo
force-pushed
the
TMS-977-sol-mint-burn-instructions
branch
from
5e15b3a to
28dcc38
Compare
| if (instruction.programId) { | ||
| programIDForMint = instruction.programId.toString(); | ||
| } | ||
| const mintTo: MintTo = { |
There was a problem hiding this comment.
suggestion can we move this common piece of code in one json generator function (for line 256-268 and 284-294)?
There was a problem hiding this comment.
MintTo and Burn take in different params, I don't think we need a common piece of code here? Or did you mean something else? If you can elaborate.
TICKET: TMS-977