-
Notifications
You must be signed in to change notification settings - Fork 300
feat(sdk-coin-cosmos): generic configuration driven test cases for sh… #6567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4d734e0 to
6d00207
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added some comments
37db72b to
b9c45d2
Compare
gianchandania
previously approved these changes
Jul 30, 2025
b9c45d2 to
b181c59
Compare
gianchandania
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements to the Cosmos SDK module, focusing on adding test utilities, type definitions, and dependencies for streamlined testing and development. The most significant changes include the addition of utility functions for test data generation, comprehensive type definitions for test data structures, and updates to the package dependencies.
Additions to test utilities and type definitions:
generateAddresses,generateTxIds,generateCoinAmounts, and other functions intest/testUtils/generators.tsto simplify the creation of test data for Cosmos SDK-based coins. These functions handle common test scenarios like generating addresses, transaction IDs, and coin amounts.test/testUtils/types.tsto define interfaces for test data structures, includingChainConfig,TestTransaction,TestAddresses,TestCoinAmounts, and others. These types ensure consistency and clarity in test data usage.Updates to package dependencies:
package.jsonto include new dependencies like@bitgo/sdk-api,@cosmjs/encoding, and@bitgo/sdk-test, which are essential for Cosmos SDK functionality and testing.Utility functions for test data management:
test/testUtils/utils.tsfor managing test data, such asgetAvailableTestCoins,getTestData, andgetAllTestData. These utilities streamline the loading and usage of test data across the test suite.Simplified exports for test utilities:
test/testUtils/index.tsto re-export all test utility modules (types,generators,utils), providing a single entry point for accessing test utilities.TICKET: COIN-4990