-
Notifications
You must be signed in to change notification settings - Fork 300
feat: deprecate holesky and onboard hoodi testnet #6575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
17e3c04 to
742d3c2
Compare
742d3c2 to
14b8621
Compare
14b8621 to
dd85438
Compare
dd85438 to
909df9d
Compare
|
@claude review |
sampras-saha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with some comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Ethereum testnet from Holesky to Hoodi testnet, updating chain IDs, network names, contract addresses, and related configuration across the codebase.
- Updates chain ID from 17000 to 560048 for hteth network mapping
- Replaces all references to "Holesky" with "Hoodi" in network names and URLs
- Updates contract addresses for tokens and test fixtures to match Hoodi testnet deployment
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/statics/src/map.ts | Updates chain ID mapping from 17000 to 560048 for hteth |
| modules/statics/src/coins.ts | Removes environment-specific logic and standardizes to Hoodi network |
| modules/statics/src/base.ts | Removes deprecated underlying asset enums for Holesky-specific tokens |
| modules/statics/src/coins/erc20Coins.ts | Updates token names, contract addresses, and removes duplicate Holesky tokens |
| modules/statics/src/coins/ofcErc20Coins.ts | Updates token display names from Holesky to Hoodi |
| modules/statics/src/account.ts | Updates documentation comments to reference Hoodi instead of Holesky |
| modules/statics/test/unit/resources/amsTokenConfig.ts | Updates test data with new network names, chain ID, and contract addresses |
| modules/sdk-test/src/bitgo/lib/test_bitgo.ts | Updates chain ID in test configuration |
| modules/sdk-core/src/bitgo/environments.ts | Updates Etherscan API URLs from Holesky to Hoodi |
| modules/sdk-coin-ethlike/test/fixtures/ethlikeCoin.ts | Updates test transaction hex data for new chain ID |
| modules/sdk-coin-eth/test/unit/transactionBuilder/send.ts | Updates test expectations and comments for Hoodi chain |
| modules/sdk-coin-eth/test/resources/eth.ts | Updates transaction hex data and chain ID in test requests |
| modules/sdk-coin-eth/test/fixtures/eth.ts | Updates chain ID in test fixture requests |
| modules/bitgo/test/v2/unit/recovery.ts | Updates chain ID expectations and temporarily disables broken tests |
| modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts | Temporarily disables tests during migration |
| modules/bitgo/test/v2/unit/baseCoin.ts | Updates test comments to reference Hoodi |
| modules/bitgo/test/v2/unit/ams/ams.ts | Updates test expectations for token names |
| modules/bitgo/test/v2/resources/amsTokenConfig.ts | Updates test configuration data |
| modules/bitgo/test/v2/lib/recovery-nocks.ts | Updates mock API chain ID parameters |
Comments suppressed due to low confidence (7)
modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:774
- Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
xit('signTxRequest should fail with wrong recipient', async function () {
modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:791
- Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
xit('signTxRequest should fail with incorrect value', async function () {
modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:811
- Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
xit('signTxRequest should fail with incorrect value for token txn', async function () {
modules/statics/src/base.ts:1100
- The underlying asset 'hteth:bgerchv3' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
'hteth:aut' = 'hteth:aut',
modules/statics/src/base.ts:1659
- The underlying asset 'HDTERC2DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
TERC6DP = 'terc6dp',
modules/statics/src/base.ts:1661
- The underlying asset 'HDTERC6DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
TERC20 = 'terc20',
modules/statics/src/base.ts:1663
- The underlying asset 'HDTERC18DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
TERC2DP2 = 'terc2dp2',
BREAKING CHANGE: deprecate holesky and onboard hoodi for ethereum testnet Ticket: COIN-5021
909df9d to
88c1f1e
Compare
sachushaji
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sampras-saha
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Phani024
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket: COIN-5021
BREAKING CHANGE: deprecate holesky and onboard hoodi for ethereum testnet