Skip to content

Conversation

@shivam-bitgo
Copy link
Contributor

@shivam-bitgo shivam-bitgo commented Jul 29, 2025

Ticket: COIN-5021

BREAKING CHANGE: deprecate holesky and onboard hoodi for ethereum testnet

@shivam-bitgo shivam-bitgo self-assigned this Jul 29, 2025
@shivam-bitgo shivam-bitgo force-pushed the COIN-5021-hoodi-test-changes branch 4 times, most recently from 17e3c04 to 742d3c2 Compare July 29, 2025 16:39
kamleshmugdiya
kamleshmugdiya previously approved these changes Jul 29, 2025
@shivam-bitgo shivam-bitgo force-pushed the COIN-5021-hoodi-test-changes branch from 14b8621 to dd85438 Compare July 29, 2025 19:16
@shivam-bitgo shivam-bitgo marked this pull request as ready for review July 29, 2025 19:31
@shivam-bitgo shivam-bitgo requested review from a team as code owners July 29, 2025 19:31
kamleshmugdiya
kamleshmugdiya previously approved these changes Jul 29, 2025
@sampras-saha
Copy link
Contributor

@claude review

Copy link
Contributor

@sampras-saha sampras-saha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some comments

@sampras-saha sampras-saha requested a review from Copilot July 30, 2025 05:50
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Ethereum testnet from Holesky to Hoodi testnet, updating chain IDs, network names, contract addresses, and related configuration across the codebase.

  • Updates chain ID from 17000 to 560048 for hteth network mapping
  • Replaces all references to "Holesky" with "Hoodi" in network names and URLs
  • Updates contract addresses for tokens and test fixtures to match Hoodi testnet deployment

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/statics/src/map.ts Updates chain ID mapping from 17000 to 560048 for hteth
modules/statics/src/coins.ts Removes environment-specific logic and standardizes to Hoodi network
modules/statics/src/base.ts Removes deprecated underlying asset enums for Holesky-specific tokens
modules/statics/src/coins/erc20Coins.ts Updates token names, contract addresses, and removes duplicate Holesky tokens
modules/statics/src/coins/ofcErc20Coins.ts Updates token display names from Holesky to Hoodi
modules/statics/src/account.ts Updates documentation comments to reference Hoodi instead of Holesky
modules/statics/test/unit/resources/amsTokenConfig.ts Updates test data with new network names, chain ID, and contract addresses
modules/sdk-test/src/bitgo/lib/test_bitgo.ts Updates chain ID in test configuration
modules/sdk-core/src/bitgo/environments.ts Updates Etherscan API URLs from Holesky to Hoodi
modules/sdk-coin-ethlike/test/fixtures/ethlikeCoin.ts Updates test transaction hex data for new chain ID
modules/sdk-coin-eth/test/unit/transactionBuilder/send.ts Updates test expectations and comments for Hoodi chain
modules/sdk-coin-eth/test/resources/eth.ts Updates transaction hex data and chain ID in test requests
modules/sdk-coin-eth/test/fixtures/eth.ts Updates chain ID in test fixture requests
modules/bitgo/test/v2/unit/recovery.ts Updates chain ID expectations and temporarily disables broken tests
modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts Temporarily disables tests during migration
modules/bitgo/test/v2/unit/baseCoin.ts Updates test comments to reference Hoodi
modules/bitgo/test/v2/unit/ams/ams.ts Updates test expectations for token names
modules/bitgo/test/v2/resources/amsTokenConfig.ts Updates test configuration data
modules/bitgo/test/v2/lib/recovery-nocks.ts Updates mock API chain ID parameters
Comments suppressed due to low confidence (7)

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:774

  • Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
    xit('signTxRequest should fail with wrong recipient', async function () {

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:791

  • Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
    xit('signTxRequest should fail with incorrect value', async function () {

modules/bitgo/test/v2/unit/internal/tssUtils/ecdsa.ts:811

  • Test has been disabled with 'xit' during the Hoodi onboarding. This test should be re-enabled and fixed to work with the new network configuration to maintain test coverage.
    xit('signTxRequest should fail with incorrect value for token txn', async function () {

modules/statics/src/base.ts:1100

  • The underlying asset 'hteth:bgerchv3' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
  'hteth:aut' = 'hteth:aut',

modules/statics/src/base.ts:1659

  • The underlying asset 'HDTERC2DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
  TERC6DP = 'terc6dp',

modules/statics/src/base.ts:1661

  • The underlying asset 'HDTERC6DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
  TERC20 = 'terc20',

modules/statics/src/base.ts:1663

  • The underlying asset 'HDTERC18DP' is being removed but may still be referenced elsewhere in the codebase. Ensure all references to this asset are also removed or updated to prevent runtime errors.
  TERC2DP2 = 'terc2dp2',

kaustubhbitgo
kaustubhbitgo previously approved these changes Jul 30, 2025
BREAKING CHANGE: deprecate holesky and onboard hoodi for ethereum testnet

Ticket: COIN-5021
Copy link
Contributor

@sachushaji sachushaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sampras-saha sampras-saha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Phani024 Phani024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivam-bitgo shivam-bitgo merged commit 543a90e into master Jul 30, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants