feat(wrw): added api key for full node txn #6581
Conversation
kamleshmugdiya
left a comment
kamleshmugdiya
left a comment
There was a problem hiding this comment.
commit lint is failing
txn COIN-4967 Add API key support to Sol module for recovery and node requests. This enables users to provide their own Alchemy API keys when making Solana node requests to improve rate limits and reliability. The apiKey parameter is optional and falls back to standard node URLs when not provided. TICKET: COIN-4967
There was a problem hiding this comment.
Pull Request Overview
This PR adds API key support to the Solana (SOL) module to enable users to provide their own Alchemy API keys for improved rate limits and reliability when making node requests. The implementation maintains backward compatibility by making the API key parameter optional.
- Added
solAlchemyNodeUrlconfiguration to environment settings for both mainnet and testnet - Updated SOL recovery methods to accept and use optional API key parameter
- Added test coverage for the new API key functionality
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/sdk-core/src/bitgo/environments.ts | Adds Alchemy node URL configurations for mainnet and testnet environments |
| modules/sdk-coin-sol/src/sol.ts | Implements API key support in node request methods and recovery options |
| modules/sdk-coin-sol/test/unit/sol.ts | Adds unit tests for API key functionality and improves type safety |
| // destination address where token should be sent before closing the ATA address | ||
| recoveryDestinationAtaAddress?: string; | ||
| programId?: string; // programId of the token | ||
| apiKey?: string; // API key for node requests |
There was a problem hiding this comment.
[nitpick] The comment should be more descriptive. Consider: '// Optional Alchemy API key for enhanced rate limits and reliability'
| apiKey?: string; // API key for node requests | |
| apiKey?: string; // Optional Alchemy API key for enhanced rate limits and reliability |
| secretKey: string; | ||
| }; | ||
| tokenContractAddress?: string; | ||
| apiKey?: string; // API key for node requests |
There was a problem hiding this comment.
[nitpick] The comment should be more descriptive and consistent with the interface above. Consider: '// Optional Alchemy API key for enhanced rate limits and reliability'
| apiKey?: string; // API key for node requests | |
| apiKey?: string; // Optional Alchemy API key for enhanced rate limits and reliability |
COIN-4967 Add API key support to Sol module for recovery and node requests. This enables users to provide their own Alchemy API keys when making Solana node requests to improve rate limits and reliability. The apiKey parameter is optional and falls back to standard node URLs when not provided.
TICKET: COIN-4967