-
Notifications
You must be signed in to change notification settings - Fork 300
feat(express): api-ts setup #6598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(express): api-ts setup #6598
Conversation
93f0488 to
779f755
Compare
zahin-mohammad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: dependencies declared but not detected in code - express
Warning: devDependencies declared but not detected in code - express
- @api-ts/response
- @api-ts/openapi-generator
The failures look relevant, please TAL
| message: t.string, | ||
| name: t.string, | ||
| bitgoJsVersion: t.string, | ||
| bitgoExpressVersion: t.string, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values always present on the response? should some of these be optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have express error type in clientRoutes catch all handler.
result = _.extend({}, result, {
message: err.message,
name: err.name || 'BitGoExpressError',
bitgoJsVersion: version,
bitgoExpressVersion: pjson.version,
});
|
779f755 to
8842c5e
Compare
Ticket: WP-5395