Skip to content

Conversation

@kaustubhbitgo
Copy link
Contributor

Ticket: WP-5395

@kaustubhbitgo kaustubhbitgo requested review from a team as code owners July 31, 2025 11:46
@kaustubhbitgo kaustubhbitgo marked this pull request as draft July 31, 2025 11:46
@kaustubhbitgo kaustubhbitgo force-pushed the WP-5395-express-initial-api-ts-and-directory-structure-setup-with-tests branch 4 times, most recently from 93f0488 to 779f755 Compare August 1, 2025 12:53
@kaustubhbitgo kaustubhbitgo marked this pull request as ready for review August 1, 2025 13:30
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 Warning: dependencies declared but not detected in code - express 
 Warning: devDependencies declared but not detected in code - express 
 - @api-ts/response 
 - @api-ts/openapi-generator 

The failures look relevant, please TAL

Comment on lines +4 to +7
message: t.string,
name: t.string,
bitgoJsVersion: t.string,
bitgoExpressVersion: t.string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values always present on the response? should some of these be optional?

Copy link
Contributor Author

@kaustubhbitgo kaustubhbitgo Aug 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have express error type in clientRoutes catch all handler.

  result = _.extend({}, result, {
    message: err.message,
    name: err.name || 'BitGoExpressError',
    bitgoJsVersion: version,
    bitgoExpressVersion: pjson.version,
  });

@kaustubhbitgo
Copy link
Contributor Author

kaustubhbitgo commented Aug 1, 2025

 Warning: dependencies declared but not detected in code - express 
 Warning: devDependencies declared but not detected in code - express 
 - @api-ts/response 
 - @api-ts/openapi-generator 

The failures look relevant, please TAL

I don't think these are failures, they are warnings. The code quality is failing due to some different error. I see them on other PRs as well.
Fixed

@kaustubhbitgo kaustubhbitgo force-pushed the WP-5395-express-initial-api-ts-and-directory-structure-setup-with-tests branch from 779f755 to 8842c5e Compare August 1, 2025 15:16
@kaustubhbitgo kaustubhbitgo changed the title chore(express): api-ts setup feat(express): api-ts setup Aug 2, 2025
@kaustubhbitgo kaustubhbitgo merged commit 18f04d1 into master Aug 4, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants