feat(utxo-core): implement buildToSignPsbt for BIP322 message signing #6611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add functionality to construct the toSign PSBT for BIP322 message verification with support for redeem scripts and witness scripts. Includes tests to verify correctness against BIP322 test vectors. Supports v0 segwit and non-segwit addresses. Taproot to be added later. Issue: BTC-2360 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
force-pushed
the
BTC-2362
branch
from
5e27ded to
11993ae
Compare
OttoAllmendinger
previously requested changes
Aug 1, 2025
Change buildToSignPsbt to directly accept a Transaction object instead of hex string, and return a Psbt object instead of hex. Similarly update buildToSpendTransaction to return a Transaction object. Issue: BTC-2362 Co-authored-by: llm-git <llm-git@ttll.de>
lcovar
approved these changes
Aug 1, 2025
davidkaplanbitgo
dismissed
OttoAllmendinger’s stale review
requested changes applied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to construct the toSign PSBT for BIP322 message verification with support for redeem scripts and witness scripts. Includes tests to verify correctness against BIP322 test vectors.
Supports v0 segwit and non-segwit addresses. Taproot to be added later.
Issue: BTC-2362