feat(sdk-coin-sol): use sol intent staking type from public types #6736
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haritkapadia
force-pushed
the
harit/use-public-types-staking-type
branch
3 times, most recently
from
8d2ced6 to
584c2dc
Compare
evanzbitgo
reviewed
Aug 20, 2025
| @@ -1,3 +1,4 @@ | |||
| import { SolStakingType } from '@bitgo/public-types'; | |||
Contributor
There was a problem hiding this comment.
use SolStakingTypeEnum instead. We are using the type enum directly, not from external
| if (isJito) return StakingType.JITO; | ||
| if (isMarinade) return StakingType.MARINADE; | ||
| if (isNative) return StakingType.NATIVE; | ||
| if (isJito) return 'JITO'; |
Contributor
There was a problem hiding this comment.
SolStakingTypeEnum.JITO
haritkapadia
force-pushed
the
harit/use-public-types-staking-type
branch
from
584c2dc to
86898f6
Compare
BREAKING CHANGE: txBuilder.stakingType now uses SolStakingTypeEnum from public-types instead of StakingType from BitGoJS. Ticket: SC-2789
haritkapadia
force-pushed
the
harit/use-public-types-staking-type
branch
from
86898f6 to
3487704
Compare
evanzbitgo
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use
SolStakingTypefrompublic-typesinstead ofStakingTypefromBitGoJSfor SOL staking transaction builders.Issue Number
Ticket: SC-2789
Type of change
How Has This Been Tested?
The project compiles.
The
StakingTypeenum definition has been removed, so if the project compiles, then all references to the enum have been removed.