Skip to content

fix(utxo-staking): improve proof of possession validation and signature #6758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2025
Merged

fix(utxo-staking): improve proof of possession validation and signature #6758

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c9df95
fix(utxo-staking): validate babylon address in proof of possession
OttoAllmendinger Aug 20, 2025
46cd679
fix(utxo-staking): update createProofOfPossession method signature
OttoAllmendinger Aug 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion modules/utxo-staking/src/babylon/stakingManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ class BitGoStakingManager extends vendor.BabylonBtcStakingManager {
stakerBtcAddress: string,
sigType: BTCSigType
): Promise<ProofOfPossessionBTC> {
if (!bech32Address.startsWith('bbn1')) {
throw new Error('invalid bech32 babylon address, must start with bbn1');
}
const signedBabylonAddress = await this.btcProvider.signMessage(
bech32Address,
sigType === BTCSigType.BIP322 ? 'bip322-simple' : 'ecdsa'
Expand All @@ -65,11 +68,16 @@ class BitGoStakingManager extends vendor.BabylonBtcStakingManager {

/**
* Creates a proof of possession for the staker based on ECDSA signature.
* @param channel - The channel for which the proof of possession is created.
* @param bech32Address - The staker's bech32 address on the babylon network.
* @param stakerBtcAddress
* @returns The proof of possession.
*/
async createProofOfPossession(bech32Address: string, stakerBtcAddress: string): Promise<ProofOfPossessionBTC> {
override async createProofOfPossession(
channel: 'delegation:create' | 'delegation:register',
bech32Address: string,
stakerBtcAddress: string
): Promise<ProofOfPossessionBTC> {
// force the ECDSA signature type
return this.createProofOfPossessionWithSigType(bech32Address, stakerBtcAddress, BTCSigType.ECDSA);
}
Expand Down