fix(sdk-coin-sol): add verification for Solana consolidation transactions #6785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohammadalfaiyazbitgo
requested review from
adityasoni-bitgo and
sasikumar-bitgo
mohammadalfaiyazbitgo
force-pushed
the
WP-3968/fix/sol-consolidation-blind-sign
branch
from
7284bb7 to
629c02b
Compare
margueriteblair
previously approved these changes
Aug 22, 2025
…ions - Add `consolidationToBaseAddress` verification option to BaseCoin interface - Implement verification logic in Solana's verifyTransaction method to ensure consolidation transactions only send funds to the wallet's root address - Add verification step to wallet.sendAccountConsolidations to validate all transactions before signing - Add unit tests to verify consolidation transaction validation - Remove debug console.dir in error handling TICKET: WP-3968
mohammadalfaiyazbitgo
force-pushed
the
WP-3968/fix/sol-consolidation-blind-sign
branch
from
629c02b to
f9207ad
Compare
mohammadalfaiyazbitgo
requested review from
margueriteblair and
zahin-mohammad
noel-bitgo
approved these changes
Sep 3, 2025
basel-bitgo
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
consolidationToBaseAddressverification option to BaseCoin interfaceTICKET: WP-3968