Skip to content

feat: added fundpsbtrequest codec #6901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2025
Merged

feat: added fundpsbtrequest codec #6901

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af7cc28
feat: added fundpsbtrequest codec
parvbitgo067 Sep 8, 2025
6bd0aec
feat: bumped public types
parvbitgo067 Sep 8, 2025
c01af4f
feat: import onchain withdraw from public types
parvbitgo067 Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/abstract-lightning/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
]
},
"dependencies": {
"@bitgo/public-types": "5.20.0",
"@bitgo/public-types": "5.22.0",
"@bitgo/sdk-core": "^36.8.0",
"@bitgo/statics": "^57.8.0",
"@bitgo/utxo-lib": "^11.10.0",
Expand Down
19 changes: 13 additions & 6 deletions modules/abstract-lightning/src/codecs/api/withdraw.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
import * as t from 'io-ts';
import { LightningOnchainRecipient, optionalString } from '@bitgo/public-types';
import { LightningOnchainRequest, optionalString } from '@bitgo/public-types';
import { PendingApprovalData, TxRequestState } from '@bitgo/sdk-core';
import { BigIntFromString } from 'io-ts-types';

export const WithdrawStatusDelivered = 'delivered';
export const WithdrawStatusFailed = 'failed';

export const WithdrawStatus = t.union([t.literal(WithdrawStatusDelivered), t.literal(WithdrawStatusFailed)]);

// todo: import LightningOnchainRequest from public-types after it is published
export const LightningOnchainWithdrawParams = t.intersection([
// LightningOnchainRequest,
LightningOnchainRequest,
t.type({
recipients: t.array(LightningOnchainRecipient),
satsPerVbyte: BigIntFromString,
passphrase: t.string,
}),
t.partial({
Expand Down Expand Up @@ -73,6 +69,17 @@ export type LightningOnchainWithdrawResponse = {
transfer?: any;
};

export const FundPsbtRequest = t.intersection(
[
LightningOnchainRequest,
t.type({
txRequestId: t.string,
}),
],
'FundPsbtRequest'
);
export type FundPsbtRequest = t.TypeOf<typeof FundPsbtRequest>;

export const FundPsbtResponse = t.type(
{
fundedPsbt: t.string,
Expand Down
2 changes: 1 addition & 1 deletion modules/bitgo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@
"superagent": "^9.0.1"
},
"devDependencies": {
"@bitgo/public-types": "5.20.0",
"@bitgo/public-types": "5.22.0",
"@bitgo/sdk-opensslbytes": "^2.0.0",
"@bitgo/sdk-test": "^9.0.9",
"@openpgp/web-stream-tools": "0.0.14",
Expand Down
2 changes: 1 addition & 1 deletion modules/express/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"superagent": "^9.0.1"
},
"devDependencies": {
"@bitgo/public-types": "5.20.0",
"@bitgo/public-types": "5.22.0",
"@bitgo/sdk-lib-mpc": "^10.7.0",
"@bitgo/sdk-test": "^9.0.9",
"@types/argparse": "^1.0.36",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
]
},
"dependencies": {
"@bitgo/public-types": "5.20.0",
"@bitgo/public-types": "5.22.0",
"@bitgo/sdk-lib-mpc": "^10.7.0",
"@bitgo/secp256k1": "^1.5.0",
"@bitgo/sjcl": "^1.0.1",
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -945,10 +945,10 @@
monocle-ts "^2.3.13"
newtype-ts "^0.3.5"

"@bitgo/public-types@5.20.0":
version "5.20.0"
resolved "https://registry.npmjs.org/@bitgo/public-types/-/public-types-5.20.0.tgz"
integrity sha512-OOVs9eGviJtSdpWvWb9uPUezM9Qyy/ERAQFifZZ8NB8Sq8RxAjMlXinzazEHveRtHi9aaEd6jxzEnatnFLCE0w==
"@bitgo/public-types@5.22.0":
version "5.22.0"
resolved "https://registry.npmjs.org/@bitgo/public-types/-/public-types-5.22.0.tgz#eec37aa28b3979c6e9ba2dda8f3bb35472b0eaad"
integrity sha512-1j9c3hYn9SmxV2oAq5NBOOS8Hpm6f9B9eKNUH1qpELrktEA/qkg4YCm4/uILWPb0BN5fluhMk0G0XCkMybt7vA==
dependencies:
fp-ts "^2.0.0"
io-ts "npm:@bitgo-forks/io-ts@2.1.4"
Expand Down