Skip to content

Conversation

@raksha-r7
Copy link
Contributor

Ticket: SC-3017

@raksha-r7 raksha-r7 marked this pull request as ready for review September 9, 2025 15:21
@raksha-r7 raksha-r7 requested a review from a team as a code owner September 9, 2025 15:21
@Doddanna17 Doddanna17 requested a review from Copilot September 10, 2025 03:40

This comment was marked as outdated.

Copy link
Contributor

@Doddanna17 Doddanna17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the comments

@raksha-r7 raksha-r7 force-pushed the SC-3017 branch 3 times, most recently from d196a1b to 68ad0d3 Compare September 10, 2025 10:17
@Doddanna17 Doddanna17 requested a review from Copilot September 10, 2025 11:54

This comment was marked as outdated.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for moving stake between hotkeys in the TAO network by implementing a new moveStakeBuilder transaction builder.

  • Adds MoveStakeBuilder and MoveStakeTransaction classes to handle move stake operations
  • Extends transaction factory to support move stake transaction type
  • Adds comprehensive test coverage for the move stake functionality

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
modules/sdk-coin-tao/test/unit/transactionBuilder/moveStakeBuilder.ts Comprehensive test suite for MoveStakeBuilder functionality
modules/sdk-coin-tao/src/lib/transactionBuilderFactory.ts Adds getMoveStakeBuilder method and factory routing
modules/sdk-coin-tao/src/lib/moveStakeTransaction.ts Transaction class for move stake operations
modules/sdk-coin-tao/src/lib/moveStakeBuilder.ts Builder class for constructing move stake transactions
modules/sdk-coin-tao/src/lib/index.ts Exports new move stake classes
modules/sdk-coin-tao/src/lib/iface.ts Adds MoveStakeTxData interface
modules/sdk-coin-tao/src/lib/constants.ts Defines TAO network constants
modules/abstract-substrate/src/lib/utils.ts Adds isMoveStake utility method
modules/abstract-substrate/src/lib/txnSchema.ts Adds validation schema for move stake transactions
modules/abstract-substrate/src/lib/iface.ts Adds move stake interfaces and method names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Doddanna17
Doddanna17 previously approved these changes Sep 11, 2025
abhijit0943
abhijit0943 previously approved these changes Sep 11, 2025
joshisakshi
joshisakshi previously approved these changes Sep 11, 2025
Doddanna17
Doddanna17 previously approved these changes Sep 11, 2025
@Doddanna17 Doddanna17 requested a review from Copilot September 11, 2025 09:50

This comment was marked as duplicate.

ravibitgo
ravibitgo previously approved these changes Sep 11, 2025
baltiyal
baltiyal previously approved these changes Sep 11, 2025
@raksha-r7 raksha-r7 merged commit 4b18287 into master Sep 12, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants