feat: blind signing guards for xrp token enablements #6941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
from
df4ea99 to
cdf00f4
Compare
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
2 times, most recently
from
592a07c to
6bcbcbd
Compare
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
from
6bcbcbd to
8920f6b
Compare
margueriteblair
previously approved these changes
Sep 12, 2025
mohammadalfaiyazbitgo
requested changes
Sep 16, 2025
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
3 times, most recently
from
43c1a6d to
3b3b253
Compare
mohammadalfaiyazbitgo
requested changes
Sep 18, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
one small change but overall lgtm.
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
from
3b3b253 to
88e768d
Compare
mtexeira-simtlix
requested review from
mohammadalfaiyazbitgo,
pranavjain97 and
rahulhegde-bitgo
pranavjain97
previously approved these changes
Sep 19, 2025
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
from
88e768d to
e7a6cf5
Compare
mohammadalfaiyazbitgo
previously approved these changes
Sep 19, 2025
prithvishet2503
previously approved these changes
Sep 22, 2025
mtexeira-simtlix
dismissed stale reviews from prithvishet2503 and mohammadalfaiyazbitgo
via
fa39c0f
mtexeira-simtlix
force-pushed
the
WP-5820_xrp_token_enablement
branch
from
e7a6cf5 to
fa39c0f
Compare
mohammadalfaiyazbitgo
approved these changes
Sep 22, 2025
prithvishet2503
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WP-5820
Description:
Blind signing guards for xrp token enablements including token name, issuer, account addr and others.