Skip to content

Conversation

@yogeshwar-bitgo
Copy link
Contributor

TICKET: WIN-7139

@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-7139 branch 3 times, most recently from b58769b to 9c97c56 Compare September 11, 2025 07:37
@yogeshwar-bitgo yogeshwar-bitgo marked this pull request as ready for review September 11, 2025 10:43
@yogeshwar-bitgo yogeshwar-bitgo requested review from a team as code owners September 11, 2025 10:43
Copy link
Contributor

@zahin-mohammad zahin-mohammad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's reduce the number of new dependencies please, looks like the only one we need is bignumber?

@yogeshwar-bitgo yogeshwar-bitgo force-pushed the WIN-7139 branch 4 times, most recently from ee5b235 to 173d088 Compare September 12, 2025 03:59
kamleshmugdiya
kamleshmugdiya previously approved these changes Sep 12, 2025
Doddanna17
Doddanna17 previously approved these changes Sep 12, 2025
Copy link
Contributor

@Doddanna17 Doddanna17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaustubhbitgo
kaustubhbitgo previously approved these changes Sep 12, 2025
Copy link
Contributor

@andrew-scott-fischer andrew-scott-fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you adding a package without regenerating the lockfile? Please rectify this.

@yogeshwar-bitgo yogeshwar-bitgo merged commit a2b4fe1 into master Sep 15, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants