-
Notifications
You must be signed in to change notification settings - Fork 300
feat(express): migrate getlightningstate to typed routes #6982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
danielzhao122
merged 9 commits into
master
from
WP-5447-express-migrate-api-v2-coin-wallet-id-state-to-typed-routes
Sep 26, 2025
Merged
feat(express): migrate getlightningstate to typed routes #6982
danielzhao122
merged 9 commits into
master
from
WP-5447-express-migrate-api-v2-coin-wallet-id-state-to-typed-routes
Sep 26, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zahin-mohammad
previously approved these changes
Sep 15, 2025
modules/express/test/unit/clientRoutes/lightning/lightningSignerRoutes.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with Zahin
OttoAllmendinger
requested changes
Sep 16, 2025
zahin-mohammad
previously approved these changes
Sep 19, 2025
adityasoni-bitgo
previously approved these changes
Sep 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
OttoAllmendinger
requested changes
Sep 22, 2025
02537bd
zahin-mohammad
previously approved these changes
Sep 24, 2025
zahin-mohammad
approved these changes
Sep 25, 2025
OttoAllmendinger
approved these changes
Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WP-5447