feat(sdk-coin-tao): correct validation stages order in move stake builder #7016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijit0943
previously approved these changes
Sep 18, 2025
Contributor
|
what's wrong with the current order? |
Gautam2305
previously approved these changes
Sep 18, 2025
kamleshmugdiya
requested changes
Sep 18, 2025
Contributor
kamleshmugdiya
left a comment
kamleshmugdiya
left a comment
There was a problem hiding this comment.
can you add a test for this?
Contributor
Author
|
this._method is being populated in super.fromImplementation, hence the the order change |
raksha-r7
dismissed stale reviews from Gautam2305 and abhijit0943
via
55e3fc7
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kamleshmugdiya
approved these changes
Sep 18, 2025
abhijit0943
approved these changes
Sep 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: SC-3168