Skip to content

fix: sequential build and sign messages #7018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: sequential build and sign messages #7018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions modules/sdk-core/src/bitgo/walletUtil/signAccountBasedMidnightClaimMessages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,13 +38,13 @@ async function bulkSignAccountBasedMessagesWithProvider(
// Extract wallet constructor params
const { bitgo, baseCoin, _wallet: walletData } = wallet as Wallet;

// Process all messages in parallel, each with a new Wallet instance
const results = await Promise.all(
allMessages.map(async (messageInfo) => {
const newWallet = new Wallet(bitgo, baseCoin, walletData);
return signOrBuildMessage(newWallet, messageInfo, messageStandardType, walletPassphrase);
})
);
// Process all messages sequentially, each with a new Wallet instance
const results: { success: boolean; address: string; txRequestId?: string }[] = [];
for (const messageInfo of allMessages) {
const newWallet = new Wallet(bitgo, baseCoin, walletData);
const result = await signOrBuildMessage(newWallet, messageInfo, messageStandardType, walletPassphrase);
results.push(result);
}
processResults(results, txRequests, failedAddresses);
return { failedAddresses, txRequests };
}
Expand Down