-
Notifications
You must be signed in to change notification settings - Fork 300
feat(sdk): added the validation for verifyTxn for trx #7065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a0464d4 to
998d67e
Compare
mohammadalfaiyazbitgo
requested changes
Sep 26, 2025
998d67e to
be6d425
Compare
mohammadalfaiyazbitgo
previously approved these changes
Sep 29, 2025
be6d425 to
2d0bb52
Compare
kamleshmugdiya
previously approved these changes
Sep 29, 2025
Contributor
kamleshmugdiya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
2d0bb52 to
4f10628
Compare
nvjsr
previously approved these changes
Sep 29, 2025
b5faa7c
4f10628 to
b5faa7c
Compare
mohammadalfaiyazbitgo
approved these changes
Sep 30, 2025
nvjsr
approved these changes
Oct 1, 2025
Contributor
nvjsr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
kamleshmugdiya
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COIN-3579
📋 Summary
This PR implements comprehensive transaction verification functionality for TRON (TRX) transfers in the BitGo SDK. The changes add robust validation for TransferContract transactions to ensure transaction integrity and security.
🔧 Changes Made
Core Implementation
Key Features
✅ Parameter validation: Ensures required fields (txParams, txPrebuild, wallet) are present
✅ Address validation: Validates owner and destination addresses using Base58 encoding
✅ Amount verification: Confirms transaction amounts match between client request and prebuild
✅ Address matching: Verifies destination addresses match recipient addresses
✅ Contract structure validation: Ensures proper TransferContract parameter structure
Error Handling
🧪 Testing