fix(express): remove hardcoded dockerfile labels #7107
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the hardcoded labels from the Dockerfile will remove the need to create a new commit when publishing a new version of
bitgo/express, which in turn will make the release process more streamlined.I'm also removing explicit references to
podmanfrom the build scripts sincedockeris used to produce the official releases ofbitgo/express. The CI job that builds the docker image on PRs continues to usepodmansince it is proving to be significantly faster thandocker(10 minutes instead ofdockerwhich errors out after 15 minutes). Unless we want to use a bigger runner, this is the best compromise I can think of.I was able to verify that the labels are still populated correctly:
Ticket: VL-3498