Skip to content

Conversation

@louib
Copy link
Contributor

@louib louib commented Sep 26, 2025

Removing the hardcoded labels from the Dockerfile will remove the need to create a new commit when publishing a new version of bitgo/express, which in turn will make the release process more streamlined.

I'm also removing explicit references to podman from the build scripts since docker is used to produce the official releases of bitgo/express. The CI job that builds the docker image on PRs continues to use podman since it is proving to be significantly faster than docker (10 minutes instead of docker which errors out after 15 minutes). Unless we want to use a bigger runner, this is the best compromise I can think of.

I was able to verify that the labels are still populated correctly:

            "Labels": {
                "created": "2025-09-26T20:17:27Z",
                "git_hash": "69e6314ac0a27b9d09dc117c9ee78bf5f6bf4bc0",
                "version": "15.1.0"
            }

Ticket: VL-3498

@louib louib force-pushed the VL-3498-remove-hardcoded-docker-labels branch 2 times, most recently from 86a8e69 to 1d685b1 Compare September 26, 2025 17:59
zahin-mohammad
zahin-mohammad previously approved these changes Sep 26, 2025
@louib louib force-pushed the VL-3498-remove-hardcoded-docker-labels branch from 1d685b1 to 2c81744 Compare September 26, 2025 18:54
@louib louib force-pushed the VL-3498-remove-hardcoded-docker-labels branch 3 times, most recently from 3a308a2 to 0659e57 Compare September 26, 2025 19:49
@louib louib force-pushed the VL-3498-remove-hardcoded-docker-labels branch from 0659e57 to 69e6314 Compare September 26, 2025 19:53
@louib louib marked this pull request as ready for review September 26, 2025 20:45
@louib louib requested review from a team as code owners September 26, 2025 20:45
@louib louib merged commit 657a2ee into master Sep 26, 2025
13 checks passed
@louib louib deleted the VL-3498-remove-hardcoded-docker-labels branch September 27, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants