-
Notifications
You must be signed in to change notification settings - Fork 300
fix: correct methods and abi for vechain #7111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3d2822f to
784d6b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please double check once
modules/sdk-coin-vet/src/lib/transactionBuilder/stakingBuilder.ts
Outdated
Show resolved
Hide resolved
modules/sdk-coin-vet/src/lib/transactionBuilder/stakingBuilder.ts
Outdated
Show resolved
Hide resolved
3b7db16 to
64d4fc8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please double confirm comments below + additionally try one more thing:
in a unit test in SDK, try building the same txn data in both coins sandbox (till the unsigned building) and compare the data, it should be same
modules/sdk-coin-vet/src/lib/transactionBuilder/stakingBuilder.ts
Outdated
Show resolved
Hide resolved
modules/sdk-coin-vet/src/lib/transactionBuilder/burnNftBuilder.ts
Outdated
Show resolved
Hide resolved
modules/sdk-coin-vet/src/lib/transactionBuilder/burnNftBuilder.ts
Outdated
Show resolved
Hide resolved
3779abe to
465c9d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Ticket: SC-3296