Skip to content

Conversation

@Gautam2305
Copy link
Contributor

Ticket: SC-3296

@Gautam2305 Gautam2305 force-pushed the SC-3296 branch 2 times, most recently from 3d2822f to 784d6b8 Compare September 27, 2025 16:35
@Gautam2305 Gautam2305 changed the title fix: use stakeAndDelegate method for vechain fix: correct methods and abi for vechain Sep 27, 2025
Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check once

@Gautam2305 Gautam2305 force-pushed the SC-3296 branch 3 times, most recently from 3b7db16 to 64d4fc8 Compare September 27, 2025 22:09
Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double confirm comments below + additionally try one more thing:

in a unit test in SDK, try building the same txn data in both coins sandbox (till the unsigned building) and compare the data, it should be same

@Gautam2305 Gautam2305 force-pushed the SC-3296 branch 3 times, most recently from 3779abe to 465c9d7 Compare September 28, 2025 12:24
Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Gautam2305 Gautam2305 marked this pull request as ready for review September 28, 2025 13:06
@Gautam2305 Gautam2305 requested a review from a team as a code owner September 28, 2025 13:06
@Gautam2305 Gautam2305 merged commit 7efc966 into master Sep 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants