Skip to content

feat: add coinfactory for token instance on test og #7118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2025
Merged

feat: add coinfactory for token instance on test og #7118

merged 1 commit into from
Sep 29, 2025

Conversation

@yash-bitgo
Copy link
Contributor

@yash-bitgo yash-bitgo commented Sep 29, 2025

Ticket: WIN-7361

nvrakesh06
nvrakesh06 previously approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@nvrakesh06 nvrakesh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

prithvishet2503
prithvishet2503 previously approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@prithvishet2503 prithvishet2503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yash-bitgo yash-bitgo marked this pull request as ready for review September 29, 2025 13:00
@yash-bitgo yash-bitgo requested review from a team as code owners September 29, 2025 13:00
lokesh-bitgo
lokesh-bitgo previously approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@lokesh-bitgo lokesh-bitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@yash-bitgo yash-bitgo force-pushed the WIN-7361-add-coinfactory-for-og-test branch from 87b564d to 69ce8cb Compare September 29, 2025 13:10
prithvishet2503
prithvishet2503 approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@prithvishet2503 prithvishet2503 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nvrakesh06
nvrakesh06 approved these changes Sep 29, 2025
View reviewed changes
Copy link
Contributor

@nvrakesh06 nvrakesh06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yash-bitgo yash-bitgo merged commit 551bc4d into master Sep 29, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nvrakesh06 nvrakesh06 nvrakesh06 approved these changes

@prithvishet2503 prithvishet2503 prithvishet2503 approved these changes

@rahulhegde-bitgo rahulhegde-bitgo Awaiting requested review from rahulhegde-bitgo rahulhegde-bitgo is a code owner automatically assigned from BitGo/wallet-platform

@adityasoni-bitgo adityasoni-bitgo Awaiting requested review from adityasoni-bitgo adityasoni-bitgo is a code owner automatically assigned from BitGo/wallet-platform

@lokesh-bitgo lokesh-bitgo Awaiting requested review from lokesh-bitgo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yash-bitgo @nvrakesh06 @lokesh-bitgo @prithvishet2503