feat(utxo-lib): improve PSBT fixture handling and fix circular imports #7245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OttoAllmendinger
force-pushed
the
BTC-2651.extend-fixtures
branch
2 times, most recently
from
40a4785 to
b11adc5
Compare
Import directly from bitgo module to prevent circular dependency error. Co-authored-by: llm-git <llm-git@ttll.de> Issue: BTC-2651
Issue: BTC-2651 Co-authored-by: llm-git <llm-git@ttll.de>
Add support for different file formats (.json, .hex, .txt) with proper type handling in fixture loading. Replace fs-extra with native fs.promises for better modularity. Issue: BTC-2651 Co-authored-by: llm-git <llm-git@ttll.de>
Add functionality to save PSBT fixtures in JSON format for testing. This helps to make the tests more robust and allows for easier debugging. Also rename `neutratedRootWalletKeys` to the more descriptive `rootWalletKeysXpubs` to better reflect its purpose. Issue: BTC-2651 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2651.extend-fixtures
branch
from
b11adc5 to
e73e640
Compare
parvbitgo067
approved these changes
Oct 16, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR enhances PSBT fixture handling by introducing type-safe utility functions supporting multiple file formats (.json, .hex, .txt), replacing fs-extra with native fs.promises, and implementing deterministic nonce creation with a fixed sessionId. It also resolves circular import issues and renames neutratedRootWalletKeys to rootWalletKeysXpubs for improved clarity.
Key changes:
- Extended fixture utilities with type-safe file format support
- Added deterministic PSBT fixtures in JSON format
- Fixed circular dependencies in testutil/mock.ts
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/utxo-lib/test/fixture.util.ts | Added getFixture function with multi-format support and replaced fs-extra with fs.promises |
| modules/utxo-lib/test/bitgo/psbt/SignVerifyPsbtAndTx.ts | Renamed neutratedRootWalletKeys, added fixture comparison test, added deterministic flag |
| modules/utxo-lib/test/bitgo/fixtures/psbt/*.json | Added PSBT fixture files in JSON format for various coins and signing states |
| modules/utxo-lib/src/testutil/psbt.ts | Added fixed sessionId for deterministic nonce creation |
| modules/utxo-lib/src/testutil/mock.ts | Fixed circular imports by importing directly from specific modules |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
davidkaplanbitgo
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the fixture utility with type-safe functions supporting
multiple file formats, adds PSBT fixtures in JSON format for testing,
implements deterministic nonce creation with fixed sessionId, and fixes a
circular dependency issue in testutil/mock.ts.
Key changes:
neutratedRootWalletKeystorootWalletKeysXpubsfor clarityIssue: BTC-2651