Skip to content

test(express): refactor few test cases #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2025
Merged

test(express): refactor few test cases #7281

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions modules/express/test/unit/typedRoutes/signTransaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ describe('SignTransaction codec tests', function () {
.send(requestBody);

// Should fail with authentication error
assert.ok(result.status === 401 || result.status >= 500);
assert.strictEqual(result.status, 401);
});
});

Expand Down Expand Up @@ -963,8 +963,9 @@ describe('SignTransaction codec tests', function () {
.set('Content-Type', 'application/json')
.send(requestBody);

// Should handle empty strings - might pass validation but fail in signing
assert.ok(result.status >= 400 || result.status === 200);
// Should fail with server error due to invalid transaction data
assert.strictEqual(result.status, 500);
result.body.should.have.property('error');
});

it('should handle very long transaction hex', async function () {
Expand Down Expand Up @@ -1000,8 +1001,9 @@ describe('SignTransaction codec tests', function () {
.set('Content-Type', 'application/json')
.send(requestBody);

// Should handle large payload
assert.ok(result.status === 200 || result.status >= 400);
// Should handle large payload successfully
assert.strictEqual(result.status, 200);
assert.strictEqual(mockWallet.signTransaction.calledOnce, true);
});

it('should handle large number of unspents', async function () {
Expand Down Expand Up @@ -1038,8 +1040,9 @@ describe('SignTransaction codec tests', function () {
.set('Content-Type', 'application/json')
.send(requestBody);

// Should handle large unspents array
assert.ok(result.status === 200 || result.status >= 400);
// Should handle large unspents array successfully
assert.strictEqual(result.status, 200);
assert.strictEqual(mockWallet.signTransaction.calledOnce, true);
});

it('should handle unspents with complex objects', async function () {
Expand Down Expand Up @@ -1080,8 +1083,9 @@ describe('SignTransaction codec tests', function () {
.set('Content-Type', 'application/json')
.send(requestBody);

// Should handle additional properties in unspents
assert.ok(result.status === 200 || result.status >= 400);
// Should handle additional properties in unspents successfully
assert.strictEqual(result.status, 200);
assert.strictEqual(mockWallet.signTransaction.calledOnce, true);
});

it('should handle keychain with many additional properties', async function () {
Expand Down