fix: Do not append text to HMAC subject if undefined #7326
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: ANT-1033
Description
This PR introduces a small change that normalizes the behaviour of
calculateHMACSubjectso that it is the same as before the v3 improvements. In particular, if text was everundefined, the returned subject would be|..|..|. Doingprefix + textresults in|..|..|undefined, which is not the same behaviour. This PR fixes this and adds tests for this edge case.Issue Number
ANT-1033
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit test
Checklist: