-
Notifications
You must be signed in to change notification settings - Fork 299
feat(sdk-coin-iota): transaction builder for iota #7348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
444a052 to
5f073db
Compare
5f073db to
0df3476
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the transaction builder infrastructure for the IOTA coin, enabling transfer transactions with validation, signing, and broadcasting capabilities.
Key Changes:
- Added transaction builder classes (
TransactionBuilder,TransferBuilder,TransactionBuilderFactory) - Implemented
TransactionandTransferTransactionclasses with full serialization support - Enhanced utility functions for validation of raw transactions, signatures, and other IOTA-specific data
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
modules/sdk-coin-iota/test/unit/utils.ts |
Expanded test coverage for utility validation functions |
modules/sdk-coin-iota/test/unit/transferTransaction.ts |
Added comprehensive tests for transfer transaction operations |
modules/sdk-coin-iota/test/unit/transactionBuilder/transferBuilder.ts |
Added tests for transfer builder functionality and validation |
modules/sdk-coin-iota/test/unit/transactionBuilder/transactionBuilderFactory.ts |
Added tests for transaction builder factory |
modules/sdk-coin-iota/test/unit/transactionBuilder/transactionBuilder.ts |
Added tests for base transaction builder |
modules/sdk-coin-iota/test/unit/keyPair.ts |
Enhanced keypair tests with address derivation |
modules/sdk-coin-iota/test/unit/iota.ts |
Added extensive transaction method tests |
modules/sdk-coin-iota/test/resources/iota.ts |
Added test data for transactions |
modules/sdk-coin-iota/src/lib/utils.ts |
Added raw transaction and signature validation |
modules/sdk-coin-iota/src/lib/transferTransaction.ts |
Implemented transfer transaction class |
modules/sdk-coin-iota/src/lib/transferBuilder.ts |
Implemented transfer transaction builder |
modules/sdk-coin-iota/src/lib/transactionBuilderFactory.ts |
Implemented factory for creating transaction builders |
modules/sdk-coin-iota/src/lib/transactionBuilder.ts |
Implemented base transaction builder |
modules/sdk-coin-iota/src/lib/transaction.ts |
Implemented base transaction class |
modules/sdk-coin-iota/src/lib/index.ts |
Added exports for new transaction classes |
modules/sdk-coin-iota/src/lib/iface.ts |
Added transaction interfaces and types |
modules/sdk-coin-iota/src/lib/constants.ts |
Added transaction-related constants |
modules/sdk-coin-iota/src/iota.ts |
Implemented transaction methods in main coin class |
modules/sdk-coin-iota/package.json |
Added lodash and blake2b dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hitansh-madan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to validate limits for edge cases, but changes generally look fine
TICKET: WIN-6890