feat(abstract-utxo): refactor address generation and test structure #7366
+460
−1,381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the generateAddress function to its own module and update imports across the codebase to maintain functionality. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
…file Move tests related to custom change wallets to their own test file for better organization. These tests were previously part of the general abstract UTXO coin test file. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Remove unnecessary coinSpecific variable from the custom change wallet test that was not used. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Move the fixed-script address generation and validation code from AbstractUtxoCoin into a separate module. This improves code organization and reuse, making the implementation more maintainable. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2652.remove-generateaddress
branch
from
ae25bc6 to
394f6ee
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Remove unused signatureThreshold from generateAddress function as it is not needed and only generates a potential warning. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
Remove redundant threshold parameter since it is fixed at 2 for our 2-of-3 multisig scripts. Also make GenerateFixedScriptAddressOptions interface internal since it's only used within this file. Issue: BTC-2652 Co-authored-by: llm-git <llm-git@ttll.de>
lcovar
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The earlier
generateAddressclass method was unnecessary and had a return type that was toocomplex. We actually only need the address string and don't care about the rest.
Issue: BTC-2652