fix(express): fixed fanoutunspents response codec #7371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for bulk fanout mode to the FanoutUnspents V2 API, which enables the creation of multiple transactions when fanning out large numbers of unspents (200 unspents per transaction).
- Adds a new
bulkparameter to the request body - Updates the response type to support both single transaction and array of transactions
- Removes URL parameter validation and authentication tests that were not applicable to this typed route test suite
- Adds comprehensive test coverage for bulk mode scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| modules/express/src/typedRoutes/api/v2/fanoutUnspents.ts | Adds bulk parameter to request body, refactors response type to support both single transaction and array responses via union type |
| modules/express/test/unit/typedRoutes/fanoutUnspentsV2.ts | Adds helper function for single transaction validation, removes inapplicable URL/auth tests, adds bulk mode test coverage including array response validation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5431