Skip to content

Conversation

@haritkapadia
Copy link
Contributor

@haritkapadia haritkapadia commented Oct 31, 2025

Description

The first commit is a refactor. We isolate recipients concept to transfer-based transactions. For delegation pool operations, the transaction sender is not always correlated with inputs and outputs (e.g. withdraw). Then we create delegation pool-based transactions with validatorAddress and amount.
There should be no behaviour changes.

The second commit adds delegation pool unlock transaction.

The third commit adds delegation pool withdraw transaction.

Issue Number

Ticket: SC-3600
Ticket: SC-3601

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Unit tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My code compiles correctly for both Node and Browser environments
  • I have commented my code, particularly in hard-to-understand areas
  • My commits follow Conventional Commits and I have properly described any BREAKING CHANGES
  • The ticket or github issue was included in the commit message as a reference
  • I have made corresponding changes to the documentation and on any new/updated functions and/or methods - jsdoc
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Ticket: SC-3600
Ticket: SC-3601

First, we isolate `recipients` concept to transfer-based transactions.
For delegation pool operations, the transaction sender is not always
correlated with inputs and outputs (e.g. withdraw).

Then we create delegation pool-based transactions with
`validatorAddress` and `amount`.
@haritkapadia haritkapadia changed the title Harit/apt unstake feat,refactor(sdk-coin-apt): delegation pool unlock and withdraw transactions Oct 31, 2025
@haritkapadia haritkapadia marked this pull request as ready for review November 3, 2025 14:38
@haritkapadia haritkapadia requested a review from a team as a code owner November 3, 2025 14:38
@haritkapadia haritkapadia merged commit ff99b9b into master Nov 3, 2025
13 checks passed
@haritkapadia haritkapadia deleted the harit/apt-unstake branch November 3, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants