feat(abstract-utxo): improve transaction format selection with PSBT defaults #7537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add unit tests for transaction format selection logic in abstract-utxo, testing various wallet configurations and their default formats. Verify PSBT defaults for testnet coins, Bitcoin mainnet, and special wallet types like distributedCustody. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
…tion Extract format selection logic to a new method getDefaultTxFormat to make the code more modular and easier to test. This simplifies getExtraPrebuildParams and improves test coverage by allowing direct testing of format selection. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
Force PSBT format for all testnet coins regardless of wallet type. Previously, only hot wallets defaulted to PSBT in testnet. Now all testnet wallets will use PSBT by default. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
Remove special case for ZCash - all testnets now default to PSBT format. Simplify conditional logic by removing unnecessary ZCash exclusions from unit tests and defaulting logic. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
…d chain list Replace hardcoded list of non-PSBT coin types with a direct call to getDefaultTxFormat method, making tests more maintainable and accurate. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
Change the default transaction format on testnets from 'psbt' to 'psbt-lite', which uses a more efficient serialization that omits full prevTx data. Add documentation for transaction format options. Issue: BTC-2732 Co-authored-by: llm-git <llm-git@ttll.de>
davidkaplanbitgo
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors and enhances transaction format selection in abstract-utxo
with a focus on PSBT (Partially Signed Bitcoin Transaction) defaults.
Changes
getDefaultTxFormatfunctionpsbt-liteformat for all testnet coins (including ZCash testnet)Default PSBT conditions:
psbt-liteformatIssue: BTC-2732, BTC-1322