feat: add tx explanation for TxIntentMismatch errors #7580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeng1
requested review from
mohammadalfaiyazbitgo,
pengyuc-bitgo and
rahulhegde-bitgo
OttoAllmendinger
requested changes
Nov 20, 2025
modules/abstract-utxo/src/transaction/descriptor/verifyTransaction.ts
Outdated
Show resolved
Hide resolved
OttoAllmendinger
requested changes
Nov 20, 2025
Contributor
OttoAllmendinger
left a comment
OttoAllmendinger
left a comment
There was a problem hiding this comment.
better deal with the string explanation -> conversion in the sdk-core errors
OttoAllmendinger
previously approved these changes
Nov 28, 2025
danielpeng1
force-pushed
the
WP-6608/tx-intent-mismatch-explanation
branch
from
f7a1cba to
b81a5e5
Compare
OttoAllmendinger
approved these changes
Nov 28, 2025
danielpeng1
requested review from
mohammadalfaiyazbitgo and
mullapudipruthvik
mohammadalfaiyazbitgo
approved these changes
Dec 1, 2025
alia-bitgo
approved these changes
Dec 2, 2025
baltiyal
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding tx explanation for TxIntentMismatch errors for UTXO and ETH-like coins.
getTxExplanationmethod in bothAbstractEthLikeNewCoinsandAbstractUtxoCointo generate detailed transaction explanations for error reporting.txExplanation.tsto use inabstractUtxoCoin.tsand bothverifyTransactionsTxIntentMismatchErrorand its subclasses.Ticket: WP-6608