feat(abstract-utxo): refactor transaction signing functionality #7676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bject Change the return type of `signTransaction` to return a transaction object instead of an object containing a txHex string. This allows callers to work with the transaction object directly before serializing it. Issue: BTC-2806 Co-authored-by: llm-git <llm-git@ttll.de>
Split the large sign.ts file into smaller, more focused modules: - signLegacyTransaction.ts for legacy transaction format - signPsbt.ts for PSBT-related signing functionality - SigningError.ts for error classes This refactoring improves code organization and makes it easier to maintain the different signing pathways. Issue: BTC-2806 Co-authored-by: llm-git <llm-git@ttll.de>
Replace signAndVerifyPsbt test with signPsbtWithMusig2Participant test to verify that this function works with a mock Musig2Participant. Issue: BTC-2806 Co-authored-by: llm-git <llm-git@ttll.de>
Refactor transaction decoding logic into separate helper functions to support both utxolib and wasm-utxo backends. Extract string-to-buffer conversion into a reusable utility function. Issue: BTC-2806 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-2806.refactor-signtx
branch
from
0ef3d03 to
1121868
Compare
parvbitgo067
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes several improvements to the transaction signing functionality in
the abstract-utxo module:
signTransactionto return a transaction object instead of an objectwith txHex string, enabling direct manipulation before serialization
maintainability:
backends
These changes improve code organization, maintainability, and provide more
flexibility for transaction handling.
Issue: BTC-2806