Skip to content

Conversation

@nayandas190
Copy link
Contributor

@nayandas190 nayandas190 commented Dec 14, 2025

Ticket: WIN-7886

  • Add atomic transaction builder integration for cross-chain operations
  • Add explainTransaction support for Export transactions
  • Add validateHopPrebuild for Export type hop transactions
  • Add verifySignatureForAtomicTransaction for signature verification
  • Add createHopTransactionParams with Export type support
  • Add unit tests for Export transaction explanation

@nayandas190 nayandas190 requested review from a team as code owners December 14, 2025 07:57
@nayandas190 nayandas190 marked this pull request as draft December 14, 2025 07:57
@nayandas190 nayandas190 force-pushed the win-7886 branch 2 times, most recently from 6efdb9d to e2ef269 Compare December 14, 2025 09:05
@nayandas190 nayandas190 marked this pull request as ready for review December 14, 2025 10:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Export C to P chain atomic transactions in the Flare (FLR) SDK coin module, enabling cross-chain operations between Flare's C-chain (EVM-compatible) and P-chain. The implementation closely follows the established patterns from the AVAX C-chain implementation.

Key Changes:

  • Integrated atomic transaction builder (FlrPLib) for cross-chain Export transactions
  • Added transaction explanation, verification, and signature validation for atomic transactions
  • Implemented hop transaction parameter creation with Export type support

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
modules/sdk-coin-flr/src/flr.ts Main implementation adding atomic transaction support including explainTransaction, verifyTransaction, validateHopPrebuild, createHopTransactionParams, and helper methods for Export C to P transactions
modules/sdk-coin-flr/src/iface.ts New interface definitions exported publicly including ExplainTransactionOptions, HopParams, HopPrebuild, and extended BuildOptions/TransactionPrebuild types
modules/sdk-coin-flr/src/index.ts Exports new iface module for public API access
modules/sdk-coin-flr/test/unit/flr.ts Unit tests for P-chain address validation, hop transaction parameters, transaction explanation, and basic transaction verification
modules/sdk-coin-flr/test/resources.ts Test data for Export C to P transactions including addresses, transaction hex values, and metadata
modules/sdk-coin-flr/package.json Added dependencies for atomic transactions (sdk-coin-flrp, secp256k1, keccak, ethereumjs-util, bignumber.js)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nayandas190
Copy link
Contributor Author

I have addressed all the above review comments.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nayandas190 nayandas190 merged commit 18d4cb0 into master Dec 15, 2025
20 checks passed
@nayandas190 nayandas190 deleted the win-7886 branch December 16, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants