feat(abstract-lightning): make valueMsat optional add valueSat support #7966
+10
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidkaplanbitgo
force-pushed
the
BTC-2775.bolt11
branch
from
a79fd4d to
6387604
Compare
davidkaplanbitgo
changed the title
The CreateInvoiceBody type is updated to: 1. Make valueMsat field optional instead of required 2. Add new optional valueSat field (numeric representation) 3. Simplify the type definition structure Also adds valueSat field to the Invoice type as a backward compatibility measure with older API versions. BTC-2775 TICKET: BTC-2775
davidkaplanbitgo
force-pushed
the
BTC-2775.bolt11
branch
from
6387604 to
ab2e237
Compare
Contributor
Author
|
audit failures are not because of my changes |
lcovar
approved these changes
Jan 23, 2026
Contributor
Author
|
Need to wait for WP PR to be merged in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CreateInvoiceBody type is updated to:
Also adds valueSat field to the Invoice type as a backward compatibility measure with older API versions.
BTC-2775