Skip to content

fix(sdk-coin-coreum): accept 32-byte addresses in isValidAddress#8333

Merged
HimanshuS2212 merged 1 commit intomasterfrom
CGARD-554
Mar 24, 2026
Merged

fix(sdk-coin-coreum): accept 32-byte addresses in isValidAddress#8333
HimanshuS2212 merged 1 commit intomasterfrom
CGARD-554

Conversation

@HimanshuS2212
Copy link
Copy Markdown
Contributor

TICKET: CGARD-554

Copy link
Copy Markdown
Contributor

@mullapudipruthvik mullapudipruthvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

No issues found. Checked for: CLAUDE.md compliance, bugs, error handling, test coverage, code comment accuracy, git history regressions, security.

If this review was useful, react with 👍. Otherwise, react with 👎.

Comment thread modules/sdk-coin-coreum/src/lib/constants.ts
Copy link
Copy Markdown
Contributor

@sachinBitgo sachinBitgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HimanshuS2212 HimanshuS2212 merged commit 6fe4bf0 into master Mar 24, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants