fix: sdk hmac strategy init & clear#8339
Merged
bitgoAaron merged 1 commit intomasterfrom Mar 25, 2026
Merged
Conversation
handle hmac strategy token init in authenticate methods, add new clearAsync to handle clearing the strategy Ticket: CE-10122
ecastro-intive
approved these changes
Mar 24, 2026
ecastro-intive
left a comment
ecastro-intive
left a comment
There was a problem hiding this comment.
lgtm.
one small note. We might want to call await sdk.clearAsync(); when clearing token on WebCryptoAuth to wipe memory session as well, otherwise an "already logged in" error shows
alextse-bg
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
handle hmac strategy token init in
authenticate methods, add new clearAsync
to handle clearing the strategy
Ticket: CE-10122