feat(sdk-core): add webauthnInfo support to bulkAcceptShare#8365
Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom Apr 1, 2026
Merged
feat(sdk-core): add webauthnInfo support to bulkAcceptShare#8365mohammadalfaiyazbitgo merged 1 commit intomasterfrom
mohammadalfaiyazbitgo merged 1 commit intomasterfrom
Conversation
derranW26
force-pushed
the
WP-8314-bulk-accept-webauthn-info
branch
from
0d54fd1 to
ada11fd
Compare
derranW26
requested review from
kaustubhbitgo,
mohammadalfaiyazbitgo and
mrdanish26
derranW26
had a problem deploying
to
npmjs-release
GitHub Actions
Failure
derranW26
had a problem deploying
to
npmjs-release
GitHub Actions
Failure
Contributor
derranW26
force-pushed
the
WP-8314-bulk-accept-webauthn-info
branch
from
4c32ac5 to
ae8092f
Compare
Contributor
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
some feedback, but otherwise lgtm.
Adds AcceptShareWebauthnInfo type and extends BulkAcceptShareOptions with optional webauthnInfo. In the ECDH branch of bulkAcceptShare(), encrypts wallet prv with PRF-derived passphrase when webauthnInfo is provided. Passphrase is consumed client-side only and never sent to server. TICKET: WP-8314
derranW26
force-pushed
the
WP-8314-bulk-accept-webauthn-info
branch
from
16e86e9 to
808a97e
Compare
mohammadalfaiyazbitgo
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AcceptShareWebauthnInfotype and extendsBulkAcceptShareOptionsandAcceptShareOptionsRequestwith optionalwebauthnInfouserMultiKeyRotationRequiredbranches ofbulkAcceptShare(), encrypts wallet prv with PRF-derived passphrase whenwebauthnInfois providedTest plan
otpDeviceId,prfSalt,encryptedPrvpresent;passphraseabsentpubstill presenttsc --noEmitpassesTicket: WP-8314