fix(sdk-coin-sol): use null check for decimalPlaces in token transfer builders#8377
Merged
ArunBala-Bitgo merged 1 commit intomasterfrom Mar 30, 2026
Merged
fix(sdk-coin-sol): use null check for decimalPlaces in token transfer builders#8377ArunBala-Bitgo merged 1 commit intomasterfrom
ArunBala-Bitgo merged 1 commit intomasterfrom
Conversation
… builders decimalPlaces of 0 (e.g. NFTs) is falsy in JS, causing buildImplementation to skip the sendParams branch and throw "Could not determine token information" during PA approval. TICKET: CECHO-606 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
abhishekagrawal080
approved these changes
Mar 30, 2026
rohitsaw115
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
decimalPlaces: 0(e.g. NFTs) causesbuildImplementationto skip thesendParamsbranch and throw "Could not determine token information" during PA approval&& sendParams.decimalPlacesto&& sendParams.decimalPlaces != nullin bothtokenTransferBuilder.tsandtransferBuilderV2.tsImpact
decimalPlacesis0(NFTs, certain tokens)uniqueDoubleSpendPreventionIds→build()path during pending approvalTest plan
customTxcompletes PA approval after deployTICKET: CECHO-606
🤖 Generated with Claude Code