fix(sdk-coin-sui): handle epoch round trip#8498
Merged
abhishekagrawal080 merged 1 commit intomasterfrom Apr 14, 2026
Merged
Conversation
e4201cc to
4247d7e
Compare
manas-at-bitgo
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TICKET: CSHLD-601
TransactionExpiration with an Epoch value could not round-trip through BCS serialization/deserialization.
When txBuilder.expiration({ Epoch: 324 }) was used and the transaction was built, the BCS bytes were correct. But factory.from(rawTx) (via TransactionDataBlock.fromBytes()) threw a StructError because the deserialized value was { Epoch: 324n } and validation expected object({ Epoch: integer() }).
Root cause:
sui-bcs.ts registers TransactionExpiration.Epoch as BCS.U64
@mysten/bcs deserializes U64 as BigInt at runtime
TransactionDataBlock.ts validated the deserialized value with object({ Epoch: integer() })
superstruct's integer() accepts JavaScript number but rejects BigInt