Skip to content

feat(kaspa): wire Kaspa into coin factory and account-lib#8514

Merged
mohd-kashif merged 1 commit into
masterfrom
feat/kaspa/pr3-integration
Apr 27, 2026
Merged

feat(kaspa): wire Kaspa into coin factory and account-lib#8514
mohd-kashif merged 1 commit into
masterfrom
feat/kaspa/pr3-integration

Conversation

@mohd-kashif
Copy link
Copy Markdown
Contributor

  • Register kaspa/tkaspa in coinFactory.ts (registerCoinConstructors + getCoinConstructor switch)
  • Import/export Kaspa, Tkaspa in bitgo/src/v2/coins/index.ts
  • Add Kaspa to account-lib coinBuilderMap (TransactionBuilderFactory)
  • Add @bitgo/sdk-coin-kaspa dependency to account-lib/package.json and bitgo/package.json
  • Add sdk-coin-kaspa tsconfig references in account-lib, bitgo, and tsconfig.packages.json
  • Add /modules/sdk-coin-kaspa/ ownership to CODEOWNERS
  • Regenerate Dockerfile via yarn update-dockerfile

Jira: CECHO-388

@mohd-kashif mohd-kashif force-pushed the feat/kaspa/pr2-sdk-module branch 5 times, most recently from ca90aa0 to 3d44df7 Compare April 21, 2026 08:12
@mohd-kashif mohd-kashif force-pushed the feat/kaspa/pr3-integration branch from 78cce2e to 2fbd674 Compare April 21, 2026 11:10
@mohd-kashif mohd-kashif changed the base branch from feat/kaspa/pr2-sdk-module to master April 21, 2026 11:10
@mohd-kashif mohd-kashif self-assigned this Apr 21, 2026
@mohd-kashif mohd-kashif marked this pull request as ready for review April 21, 2026 11:11
@mohd-kashif mohd-kashif requested review from a team as code owners April 21, 2026 11:11
@mohd-kashif mohd-kashif force-pushed the feat/kaspa/pr3-integration branch 2 times, most recently from 75e2b0d to 876b777 Compare April 21, 2026 11:50
@mohd-kashif mohd-kashif marked this pull request as draft April 22, 2026 11:06
@mohd-kashif mohd-kashif force-pushed the feat/kaspa/pr3-integration branch 2 times, most recently from 978fa89 to ee1a5bd Compare April 23, 2026 06:09
@mohd-kashif mohd-kashif marked this pull request as ready for review April 23, 2026 06:09
- Register kaspa/tkaspa in coinFactory.ts (both routed to Kaspa.createInstance)
- Import/export Kaspa in bitgo/src/v2/coins/index.ts
- Add Kaspa to account-lib coinBuilderMap (TransactionBuilderFactory)
- Add @bitgo/sdk-coin-kaspa dependency to account-lib/package.json and bitgo/package.json
- Add sdk-coin-kaspa tsconfig references in account-lib, bitgo, and tsconfig.packages.json
- Add /modules/sdk-coin-kaspa/ ownership to CODEOWNERS
- Regenerate Dockerfile via yarn update-dockerfile

Jira: CECHO-388
@mohd-kashif mohd-kashif force-pushed the feat/kaspa/pr3-integration branch from bb29427 to 43d7ecd Compare April 23, 2026 07:24
@lokesh-bitgo
Copy link
Copy Markdown
Contributor

@claude Please do a thorough review of this PR.

Focus especially on:

  • any bugs or incorrect logic in the changes
  • whether these changes could impact existing flows or cause regressions
  • whether the implementation is aligned with the requirement/design
  • whether the changes are correct and complete
  • missing edge cases, validation gaps, and test coverage gaps
    Please call out concrete issues clearly and separate them by severity if possible.

@mohd-kashif mohd-kashif merged commit 3753e42 into master Apr 27, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants