fix(abstract-utxo): guard address in checkRecipient for OP_RETURN outputs#8649
Merged
mohammadalfaiyazbitgo merged 1 commit intomasterfrom Apr 29, 2026
Merged
Conversation
…puts What changed: - make address optional in checkRecipient parameter type - add recipient.address guard before calling isScriptRecipient - pass explicit object to super.checkRecipient to satisfy its address: string type - add unit tests covering OP_RETURN and script-prefixed recipient cases Why: OP_RETURN recipients have no address field at runtime; calling isScriptRecipient(undefined) unconditionally invoked undefined.toLowerCase() causing a crash when approving pending approvals containing OP_RETURN outputs. TICKET: WAL-826 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
mohammadalfaiyazbitgo
force-pushed
the
worktree-wal-826-fix-check-recipient
branch
from
7b3d49d to
5f0d1ed
Compare
davidkaplanbitgo
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addressoptional incheckRecipientparameter type to reflect runtime realityrecipient.address &&guard before callingisScriptRecipientto prevent crash whenaddressis undefinedsuper.checkRecipientto satisfy itsaddress: stringconstraint after the type narrowsTest Plan
modules/abstract-utxo/test/unit/transaction/recipient.tsall pass (5 tests)pendingApproval.approve()on a BTC wallet with an OP_RETURN output inbuildParams.recipientsTicket
WAL-826