feat(abstract-utxo): enhance BIP-322 verification in wasm-utxo#8653
Merged
OttoAllmendinger merged 2 commits intomasterfrom Apr 29, 2026
Merged
feat(abstract-utxo): enhance BIP-322 verification in wasm-utxo#8653OttoAllmendinger merged 2 commits intomasterfrom
OttoAllmendinger merged 2 commits intomasterfrom
Conversation
OttoAllmendinger
changed the title
OttoAllmendinger
force-pushed
the
BTC-0.bip322-fixes
branch
from
81f44b1 to
7cefc44
Compare
Extend explainPsbtWasm to count valid signatures per input: - Add scriptId to ExplainedInput (from parseTransactionWithWalletKeys) - Add signedBy map showing validation status for each key - Extract BIP-322 messages with bip322.getBip322Message() - Count signatures via bip322.verifyBip322PsbtInput() Replace BIP-322 test fixtures with dynamic PSBT generation using wasm-utxo. Remove fixtures/bip322/fixtures.ts and inline PSBT construction directly in tests. Call explainPsbtWasm with BitGoPsbt instances instead of serializing via coin.explainTransaction. Remove utxolib dependency from BIP-322 tests. Use @bitgo/wasm-utxo directly for key generation, address creation, and signature verification. Rewrite p2trMusig2 sighashType test as pure wasm-utxo round-trip. Add cross-library compatibility test verifying utxolib-created BIP-322 PSBTs can be signed by wasm-utxo and validated by utxolib. Issue: BTC-2650 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-0.bip322-fixes
branch
from
7cefc44 to
b6b6166
Compare
davidkaplanbitgo
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend explainPsbtWasm to count valid signatures per input:
Replace BIP-322 test fixtures with dynamic PSBT generation using
wasm-utxo. Remove fixtures/bip322/fixtures.ts and inline PSBT
construction directly in tests. Call explainPsbtWasm with BitGoPsbt
instances instead of serializing via coin.explainTransaction.
Remove utxolib dependency from BIP-322 tests. Use @bitgo/wasm-utxo
directly for key generation, address creation, and signature
verification. Rewrite p2trMusig2 sighashType test as pure wasm-utxo
round-trip.
Issue: BTC-2650