feat(abstract-utxo)!: default to wasm-utxo for all coins#8674
Merged
Conversation
- Add `pubs` parameter to all `signTransaction` calls for consistency - Fix test to properly sign non-standard 2-of-2 multisig scripts - Skip p2shP2pk tests when replay protection key is unavailable - Use WASM implementation for generating musig2 nonces in mock Issue: BTC-2650 Co-authored-by: llm-git <llm-git@ttll.de>
The test overrode a P2WSH input's witnessScript while leaving witness_utxo.script_pubkey (the output commitment) unchanged, creating a PSBT whose inner script and output hash disagree. Such a transaction is unspendable on-chain regardless of signing outcome. The expected 'length mismatch' error was a utxolib implementation artifact with no security meaning. Issue: BTC-2650
Utxolib backend is deprecated Issue: BTC-2650
Remove references to utxolib backend and SdkBackend parameter from transaction tests. Simplifies test suite by using only wasm-utxo backend, removing conditional logic and backend selection parameters. Issue: BTC-2650 Co-authored-by: llm-git <llm-git@ttll.de>
OttoAllmendinger
force-pushed
the
BTC-0.deprecate-utxolib-on-nonprod
branch
from
2c70639 to
7e72cf2
Compare
Change defaultSdkBackend from a getter to a property with constant value 'wasm-utxo', removing network-based logic that favored utxolib for mainnet coins. This is effectively a noop since wallet-platform has been responding with the `decodeWith: 'wasm-utxo'` hint for many months. BREAKING CHANGE: mainnet coins now default to wasm-utxo instead of utxolib Co-authored-by: llm-git <llm-git@ttll.de> Issue: BTC-2650
Introduce supportedSdkBackends property to gate backend availability and validate SDK backend support before decoding PSBTs. Co-authored-by: llm-git <llm-git@ttll.de> Issue: BTC-2650
OttoAllmendinger
force-pushed
the
BTC-0.deprecate-utxolib-on-nonprod
branch
from
7e72cf2 to
79849ce
Compare
davidkaplanbitgo
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change defaultSdkBackend from a getter to a property with constant
value 'wasm-utxo', removing network-based logic that favored utxolib
for mainnet coins.
Introduce supportedSdkBackends property to gate backend availability
and validate SDK backend support before decoding PSBTs.
Remove references to utxolib backend and SdkBackend parameter from
transaction tests. Simplifies test suite by using only wasm-utxo
backend, removing conditional logic and backend selection parameters.
BREAKING CHANGE: mainnet coins now default to wasm-utxo instead of
utxolib
Issue: BTC-2650