fet(hbar): add AccountUpdate support to explainTransaction in BitGoJS#8700
fet(hbar): add AccountUpdate support to explainTransaction in BitGoJS#8700Doddanna17 merged 1 commit intomasterfrom
Conversation
Doddanna17
left a comment
There was a problem hiding this comment.
Fix is correct and necessary. Without the cryptoUpdateAccount case, verifyTransaction throws for all staking ops since explainTransaction is called internally for every transaction type.
Two notes: (1) PR title typo — fet(hbar) → feat(hbar). (2) Unstake test is missing id, timestamp, memo assertions that the stake test has — inconsistency could mask regressions.
LGTM.
…in BitGoJS ticket: SI-511
Doddanna17
left a comment
There was a problem hiding this comment.
Fix is correct and necessary. Without the cryptoUpdateAccount case, verifyTransaction throws for all staking ops since explainTransaction is called internally for every transaction type.
Two notes: (1) PR title typo — fet(hbar) → feat(hbar). (2) Unstake test is missing id, timestamp, memo assertions that the stake test has — inconsistency could mask regressions.
LGTM.
ticket: SI-511