Skip to content

fet(hbar): add AccountUpdate support to explainTransaction in BitGoJS#8700

Merged
Doddanna17 merged 1 commit intomasterfrom
SI-511
May 6, 2026
Merged

fet(hbar): add AccountUpdate support to explainTransaction in BitGoJS#8700
Doddanna17 merged 1 commit intomasterfrom
SI-511

Conversation

@aditya-bitgo
Copy link
Copy Markdown
Contributor

ticket: SI-511

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 6, 2026

@aditya-bitgo aditya-bitgo marked this pull request as ready for review May 6, 2026 16:21
@aditya-bitgo aditya-bitgo requested a review from a team as a code owner May 6, 2026 16:21
Copy link
Copy Markdown
Contributor

@Doddanna17 Doddanna17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is correct and necessary. Without the cryptoUpdateAccount case, verifyTransaction throws for all staking ops since explainTransaction is called internally for every transaction type.

Two notes: (1) PR title typo — fet(hbar)feat(hbar). (2) Unstake test is missing id, timestamp, memo assertions that the stake test has — inconsistency could mask regressions.

LGTM.

Copy link
Copy Markdown
Contributor

@Doddanna17 Doddanna17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix is correct and necessary. Without the cryptoUpdateAccount case, verifyTransaction throws for all staking ops since explainTransaction is called internally for every transaction type.

Two notes: (1) PR title typo — fet(hbar)feat(hbar). (2) Unstake test is missing id, timestamp, memo assertions that the stake test has — inconsistency could mask regressions.

LGTM.

@Doddanna17 Doddanna17 merged commit 648e34f into master May 6, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants